feat(parser): add type for values parsed by DynamoDBStreamRecord #4793
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
dreamorosi
left a comment
dreamorosi
left a comment
There was a problem hiding this comment.
Thanks for the PR.
You'll need to export the type also from here, of you won't be able to import it.
sdangol
changed the title
|
@dreamorosi oops, thanks for spotting - have amended. |
|
@benthorner the unit tests are failing, can you have a look? |
dreamorosi
dismissed stale reviews from svozza and themself
CI tests are failing
|
Hi @benthorner, please review the contributing guidelines and setup your local environment to test the changes. If the CI keeps turning red we might close the PR. |
In response to [^1]. [^1]: aws-powertools#4784
|
@dreamorosi @svozza sorry about that: I was being lazy thinking it was a "oneliner" and didn't consider you having to approve CI each time to check. I've now run Thanks for your patience - should be ready to go now. |
|
|
Hi @benthorner - thank you for the PR and for addressing the issues! |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
3 participants
Summary
Changes
DynamoDBStreamRecordtype intypes/schema.ts.Issue number: closes #4784
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.